Handle nil *time.Time Literal #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
- Coverage 80.48% 80.38% -0.11%
==========================================
Files 17 17
Lines 2337 2340 +3
==========================================
Hits 1881 1881
- Misses 349 351 +2
- Partials 107 108 +1
Continue to review full report at Codecov.
|
|
@RoarkeRandall can you please provide test coverage for your change? |
|
any chance of merging this? |
|
Any update? |
|
If someone can add a test Ill get this merged, otherwise Ill wait until I have some time to add a test |
quetz
pushed a commit
to quetz/goqu
that referenced
this pull request
Dec 15, 2018
doug-martin
pushed a commit
that referenced
this pull request
Jun 8, 2019
Merged
doug-martin
added a commit
that referenced
this pull request
Jun 8, 2019
* Handle nil *time.Time Literal (PR #52) + test * Added sql to test
|
This will be in the next release I took the other pr with tests and merged into v6.10-rc with #82 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.